Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-flexbox] Clarify automatic min size's definition if both specified size and aspect ratio are not present #671

Closed
shinglyu opened this issue Nov 2, 2016 · 0 comments
Closed

[css-flexbox] Clarify automatic min size's definition if both specified size and aspect ratio are not present #671

shinglyu opened this issue Nov 2, 2016 · 0 comments
Labels
Closed Accepted as Obvious Bugfix css-flexbox-1 Current Work Tracked in DoC
Milestone
css-flexbox-1 201...

Comments

@shinglyu
Copy link
Contributor

shinglyu commented Nov 2, 2016

https://drafts.csswg.org/css-flexbox/#min-size-auto

In the section:

In general, the automatic minimum size is the smaller of its content size and its specified size. However, if the box has an aspect ratio and no specified size, its automatic minimum size is the smaller of its content size and its transferred size.

The case which no specified size and no aspect ratio is present is not clear. People might get confused and use the old default 0.

In the previous edition, it is clear that we should use content size in that case.
@shinglyu shinglyu mentioned this issue Nov 7, 2016
Open
shinglyu added a commit to shinglyu/csswg-drafts that referenced this issue Nov 8, 2016
@shinglyu
[css-flexbox] Clarify implied minimum size definition
7d64cfb 
Fixes w3c#671. In the [old version](https://hg.csswg.org/drafts/rev/25641c92d33f) this case was specified, but dropped while changing from a table to a paragraph.

r? @dbaron
@shinglyu shinglyu mentioned this issue Nov 8, 2016
Merged
tabatkins pushed a commit that referenced this issue Nov 22, 2016
@shinglyu @tabatkins
[css-flexbox] Clarify implied minimum size definition (#693)
03cead7 
Fixes #671. In the [old version](https://hg.csswg.org/drafts/rev/25641c92d33f) this case was specified, but dropped while changing from a table to a paragraph.

r? @dbaron
@fantasai fantasai added this to the Published css-flexbox-1 2017-10-19 milestone Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted as Obvious Bugfix css-flexbox-1 Current Work Tracked in DoC
Projects
None yet
Milestone
css-flexbox-1 2017-10-19+
Development

No branches or pull requests
2 participants
@fantasai @shinglyu