Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-counter-styles-3] Setting CSSCounterStyleRule.name should ignore symbolic counter styles #8186

Closed
cdoublev opened this issue Dec 5, 2022 · 4 comments
Closed

[css-counter-styles-3] Setting CSSCounterStyleRule.name should ignore symbolic counter styles #8186

cdoublev opened this issue Dec 5, 2022 · 4 comments
Labels
Closed Accepted as Obvious Bugfix css-counter-styles-3 Current Work

Comments

@cdoublev
Copy link
Collaborator

cdoublev commented Dec 5, 2022

If I am not mistaken, CSSCounterStyleRule.name should ignore symbolic counter styles, because they are invalid.

The keywords decimal, disc, square, circle, disclosure-open, and disclosure-closed are valid <counter-style-name>s, but are invalid when used here to name a counter style rule; doing so makes the rule invalid (related issue: #3584).

https://drafts.csswg.org/css-counter-styles-3/#the-counter-style-rule

-  If the value is not "decimal", "disc", or "none", replace the associated rule’s name with an identifier equal to the value.
+  If the value is not "decimal", "disc", "square", "circle", "disclosure-open", "disclosure-closed", or "none", replace the associated rule’s name with an identifier equal to the value.
@Loirooriol
Copy link
Contributor

Seems that Blink and Gecko already check that.
Would be better to define the list in a single place, and refer to it from the other place.

@Loirooriol Loirooriol added the css-counter-styles-3 Current Work label Dec 5, 2022
tabatkins added a commit that referenced this issue May 25, 2023
@tabatkins
[css-counter-styles] Abstract the list of non-overrideable counter-st…
ff3be64 
…yle names and use it directly. #8186
@tabatkins
Copy link
Member

Agreed, that was an oversight in updating. I've switched to defining the list as a term, and referencing it in both places.

Agenda+ to confirm the edit.

@vitorroriz
Copy link

Seems that Blink and Gecko already check that. Would be better to define the list in a single place, and refer to it from the other place.

Sounds good. WebKit also checks it.

@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed [css-counter-styles-3] Setting `CSSCounterStyleRule.name` should ignore symbolic counter styles, and agreed to the following:

  • RESOLVED: Accept edits
The full IRC log of that discussion <emilio> TabAtkins: again obvious bug-fix, I had two places which reference the special counter-styles
<emilio> ... didn't keep them in sync
<emilio> ... so cssom had a shorter version of the list
<emilio> ... I've made the list a defined term and reference in both places
<emilio> ... only needs sign-off
<emilio> ... also impls do this correctly
<emilio> RESOLVED: Accept edits

@mozilla-apprentice mozilla-apprentice mentioned this issue Jun 21, 2023
Open
@chromium-helper chromium-helper mentioned this issue Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted as Obvious Bugfix css-counter-styles-3 Current Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tabatkins @Loirooriol @vitorroriz @cdoublev @css-meeting-bot