Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-counter-styles-3] Korean counter styles fallback #8870

Closed
nt1m opened this issue May 24, 2023 · 4 comments
Closed

[css-counter-styles-3] Korean counter styles fallback #8870

nt1m opened this issue May 24, 2023 · 4 comments
Labels
Closed Accepted as Obvious Bugfix css-counter-styles-3 Current Work

Comments

@nt1m
Copy link
Member

nt1m commented May 24, 2023

WPT & Chrome & Firefox say that Korean counter styles should fallback to cjk-decimal. WebKit and the spec don't mention a fallback for Korean counter styles.

Given CJK stands for Chinese/Japanese/Korean, I assume this is just the spec overlooking the fallback?

cc @fantasai @tabatkins
@nt1m nt1m added the css-counter-styles-3 Current Work label May 24, 2023
@tabatkins
Copy link
Member

...huh. Okay, doing some archeology, I find that 7ebc754 is the commit that switched the Korean styles from being defined in prose to being defined with @counter-style; the deleted text clearly said that all of them should use cjk-decimal as fallback, but for some reason I only added that descriptor for the japanese styles.

A week prior, this email between me and Koji established that we should fallback to cjk-decimal; that was implemented in 20a3d9c.

So as far as I can tell, I just made a mistake and nobody ever caught it? I suppose I'll put the fallback back in the spec. ^_^

@tabatkins
Copy link
Member

Uggggh, this was committed in fd972cf along with some editorial markup fixes; I'd meant to commit these two separately but accidentally typo'd the first commit and didn't realize so instead they got committed together. Oh well.

@tabatkins
Copy link
Member

Agenda+ to confirm the change, since this is CR.

@nt1m nt1m mentioned this issue May 26, 2023
Open
nt1m added a commit to nt1m/WebKit that referenced this issue May 26, 2023
@nt1m
[css-counter-styles] Korean counter styles should fallback to cjk-dec…
4deaa32 
…imal

https://bugs.webkit.org/show_bug.cgi?id=257355
rdar://109854809

Reviewed by NOBODY (OOPS!).

Per w3c/csswg-drafts#8870 , the fallback should be cjk-decimal.

* LayoutTests/TestExpectations:
* Source/WebCore/css/counterStyles.css:
(@counter-style korean-hangul-formal):
(@counter-style korean-hanja-informal):
(@counter-style korean-hanja-formal):
@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed [css-counter-styles-3] Korean counter styles fallback, and agreed to the following:

  • RESOLVED: Accept edits from the issue
The full IRC log of that discussion <emilio> TabAtkins: real quick rubber-stamp. Several years back we agreed that korean falls back to cjk decimal but I did it wrong
<emilio> ... and accidentally default to decimal now
<emilio> RESOLVED: Accept edits from the issue

@mozilla-apprentice mozilla-apprentice mentioned this issue Jun 21, 2023
Open
@chromium-helper chromium-helper mentioned this issue Jun 21, 2023
Closed
@nt1m nt1m closed this as completed Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted as Obvious Bugfix css-counter-styles-3 Current Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tabatkins @nt1m @css-meeting-bot