Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-view-transitions-2] Consider allowing ::view-transition-group(.class) without * #9874

Closed
noamr opened this issue Jan 29, 2024 · 5 comments · Fixed by #10153
Closed

[css-view-transitions-2] Consider allowing ::view-transition-group(.class) without * #9874

noamr opened this issue Jan 29, 2024 · 5 comments · Fixed by #10153
Labels
css-view-transitions-2 View Transitions; New feature requests Needs Edits

Comments

@noamr
Copy link
Collaborator

noamr commented Jan 29, 2024

This would be consistent with how class selectors work outside of view-transitions.
@vmpstr vmpstr added the css-view-transitions-2 View Transitions; New feature requests label Jan 29, 2024
@vmpstr
Copy link
Member

vmpstr commented Jan 29, 2024

Probably to go with #9626 as well

@khushalsagar khushalsagar added Agenda+ Async Resolution: Proposed Candidate for auto-resolve with stated time limit labels Mar 18, 2024
@astearns
Copy link
Member

Right. I believe :active-view-transition is meant to cover this case

#9972 (comment)

(if I am incorrect, please re-open this issue)

@astearns astearns removed Agenda+ Async Resolution: Proposed Candidate for auto-resolve with stated time limit labels Mar 19, 2024
@vmpstr
Copy link
Member

vmpstr commented Mar 19, 2024 •
edited

This is a separate issue. #9972 only dealt with :active-view-transition* pseudo classes.

This issue is about allowing ::view-transition-* pseudo elements to also omit the asterisk if a class is specified. Note that I think we would still want to require the asterisk if there is no class or specific name specified, but that can be discussed

@vmpstr vmpstr reopened this Mar 19, 2024
@vmpstr vmpstr added the Agenda+ label Mar 19, 2024
@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed [css-view-transitions-2] Consider allowing `::view-transition-group(.class)` without *, and agreed to the following:

  • RESOLVED: Make * optional if you are using a class.
The full IRC log of that discussion <keithamus> vmpstr: we have VT pseudo elements. They take a name param, or universal selector *. We also added vt classes that specify a name and set of classes that are written as .foo.bar.
<fantasai> +1 to allowing the * to be dropped
<keithamus> vmpstr: because of the syntax currently specified, universal selector with class you need to spell out *.foo. We'd like to resolve to have * optional if you're using class param. Would look similar to how CSS looks with .class. Other point is that if we dont have a class, Id prefer to require a * - not requiring ()
<fantasai> +1 to the proposal
<keithamus> emilio: how are they defined? Selector syntax? Or custom
<keithamus> vmpstr: custom
<keithamus> khush: args to pseudo element
<keithamus> vmpstr: yes, syntax to the arg is specified in VT spec
<keithamus> astearns: you're talking about omitting * if using class? This is not just optionally omitting but making *.class syntax invalid?
<keithamus> vmpstr: no, optionally
<khush> +1
<keithamus> PROPOSED RESOLUTION: Make * optional if you are using a class.
<emilio> Sgtm
<keithamus> RESOLVED: Make * optional if you are using a class.
<keithamus> astearns: also omitting parens entirely?
<keithamus> vmpstr: the way the resolution is phrased Im happy. If its optional altogether Id like it to not be optional. This resolution satisfies that.
<keithamus> astearns: can scroll go to next week or?
<keithamus> fantasai: no, this one is about alignment property.

@mozilla-apprentice mozilla-apprentice mentioned this issue Mar 27, 2024
Open
@chromium-helper chromium-helper mentioned this issue Mar 27, 2024
Closed
noamr added a commit to noamr/csswg-drafts that referenced this issue Mar 28, 2024
@noamr
[css-view-transitions-2] Allow pseudo-element with class and no *
e317579 
Based on resolution:
w3c#9874 (comment)

Closes w3c#9874
@noamr noamr mentioned this issue Mar 28, 2024
Merged
noamr added a commit that referenced this issue Mar 28, 2024
@noamr
[css-view-transitions-2] Allow pseudo-element with class and no * (#1…
127f19f 
…0153)

Based on resolution:
#9874 (comment)

Closes #9874
@cdoublev
Copy link
Collaborator

I guess whitespaces are invalid between tokens matching these productions.

<pt-name-and-class-selector> = <pt-name-selector><pt-class-selector>? | <pt-class-selector>
<pt-class-selector> = ['.' <custom-ident>]+

Would it be possible to clarify it explicitly (like for selector productions), and add a whitespace between <pt-name-selector> and <pt-class-selector>??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css-view-transitions-2 View Transitions; New feature requests Needs Edits
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[css-view-transitions-2] Allow pseudo-element with class and no * noamr/csswg-drafts
6 participants
@noamr @astearns @vmpstr @cdoublev @css-meeting-bot @khushalsagar